Use a unique database manager and integrate it with the queue #496

TomasTurina · 2025-01-09T18:13:33Z

Related issue
#122

Description

This PR includes the following improvements:

Usage of the Persistence class in all the agent code.
Several improvements and generalizations made to the SQLiteManager class.
Column class better organized.
Removed some unused code.
Some bug fixes in database operations functions.

Tests

Compilation without warnings in every supported platform
- Linux
- Windows
- MAC OS X

LucioDonda

just leaved some comments with column types doubts

src/agent/db_manager/src/sqlite_manager.cpp

src/agent/db_manager/include/column.hpp

src/agent/command_store/src/command_store.cpp

jr0me

Some minor changes requested but looking good!

src/agent/agent_info/src/agent_info_persistance.hpp

src/agent/agent_info/src/agent_info_persistance.cpp

src/agent/command_store/include/command_store.hpp

src/agent/multitype_queue/CMakeLists.txt

src/agent/multitype_queue/include/storage.hpp

src/agent/multitype_queue/src/storage.cpp

src/agent/persistence/include/column.hpp

src/agent/persistence/include/sqlite_manager.hpp

src/agent/persistence/CMakeLists.txt

… names confict

jr0me

LGTM!

LucioDonda

LGTM! just minor comment.

src/agent/persistence/tests/sqlite_manager_test.cpp

cborla

LGTM

TomasTurina self-assigned this Jan 9, 2025

TomasTurina linked an issue Jan 9, 2025 that may be closed by this pull request

Unify the usage of the sqlite manager in the new agent #122

Closed

2 tasks

TomasTurina added 7 commits January 10, 2025 13:58

fix: use namespace sqlite_manager to simplify code

7d3f05e

fix: improve command store operations

b36eadb

fix: improve sqlite manager function, mutex usage, columns improvement

8b6ef85

fix: remove unused function from multitype queue

9c3b735

fix: organize database and column names

fdaa304

feat: add order by and limit to select query

146b37f

feat: add functions to calculate row size to sqlite manager

79afad7

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from 72f35ac to 2092181 Compare January 10, 2025 13:58

LucioDonda reviewed Jan 10, 2025

View reviewed changes

src/agent/db_manager/src/sqlite_manager.cpp Outdated Show resolved Hide resolved

src/agent/db_manager/include/column.hpp Outdated Show resolved Hide resolved

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from ed2e1f6 to ffd8732 Compare January 10, 2025 21:35

jr0me reviewed Jan 13, 2025

View reviewed changes

src/agent/command_store/src/command_store.cpp Outdated Show resolved Hide resolved

refactor: change sqlite_manager name to persistence

db73338

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from 27afe97 to 755459a Compare January 13, 2025 18:20

jr0me reviewed Jan 14, 2025

View reviewed changes

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch 3 times, most recently from ca71726 to acc88b4 Compare January 14, 2025 19:51

TomasTurina added 2 commits January 14, 2025 20:01

feat: create persistence component with persistence and sqlite_manager

6fb3483

refactor: remove sqlite references where not necessary

6e4501b

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from acc88b4 to 0505828 Compare January 14, 2025 20:07

TomasTurina added 5 commits January 14, 2025 20:12

feat: integrate db_manager in multitype_queue

2e46eee

refactor: change multitype queue comments format

825f244

feat: add module type to multitype_queue functions

f6a3765

fix: propagate exception in case of create table failure

27a26bc

feat: replace booleans with flags in columns

79a5fe6

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from 0505828 to 224cdd0 Compare January 14, 2025 20:13

TomasTurina marked this pull request as ready for review January 14, 2025 20:34

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from af05cb7 to 0111440 Compare January 14, 2025 20:43

TomasTurina added 2 commits January 14, 2025 20:44

fix: escape single quotes in sqlite manager

3385228

feat: create namespace column to enclose everything related and avoid…

ac5d8d9

… names confict

TomasTurina force-pushed the enhancement/122-unify-sqlite-manager branch from 0111440 to ac5d8d9 Compare January 14, 2025 20:45

jr0me approved these changes Jan 14, 2025

View reviewed changes

LucioDonda reviewed Jan 15, 2025

View reviewed changes

src/agent/persistence/tests/sqlite_manager_test.cpp Outdated Show resolved Hide resolved

cborla approved these changes Jan 15, 2025

View reviewed changes

fix: remove unnecesary cout usages in agent tests

bd22198

TomasTurina merged commit e3e7b5f into master Jan 15, 2025
5 checks passed

TomasTurina deleted the enhancement/122-unify-sqlite-manager branch January 15, 2025 16:11

vikman90 mentioned this pull request Jan 21, 2025

Enable Module Name and Type Filtering in DB size measure functions #419

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a unique database manager and integrate it with the queue #496

Use a unique database manager and integrate it with the queue #496

TomasTurina commented Jan 9, 2025 •

edited

Loading

LucioDonda left a comment

jr0me left a comment

jr0me left a comment

LucioDonda left a comment

cborla left a comment

Use a unique database manager and integrate it with the queue #496

Use a unique database manager and integrate it with the queue #496

Conversation

TomasTurina commented Jan 9, 2025 • edited Loading

Description

Tests

LucioDonda left a comment

Choose a reason for hiding this comment

jr0me left a comment

Choose a reason for hiding this comment

jr0me left a comment

Choose a reason for hiding this comment

LucioDonda left a comment

Choose a reason for hiding this comment

cborla left a comment

Choose a reason for hiding this comment

TomasTurina commented Jan 9, 2025 •

edited

Loading